Skip to content

Fix release instructions. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Fix release instructions. #746

merged 1 commit into from
Jun 13, 2025

Conversation

@cheftako
Copy link
Contributor

@cheftako cheftako commented May 29, 2025

Ensure the how to create a branch instructions are before tagging the branch.
Fixed the location for looking up image locations.
Added us of RELEASE variable to branch tagging instructions.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2025
@cheftako cheftako requested a review from jkh52 May 29, 2025 18:19
@k8s-ci-robot k8s-ci-robot requested review from elmiko and ipochi May 29, 2025 18:19
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2025
@cheftako
Copy link
Contributor Author

cheftako commented May 29, 2025

/assign @tallclair

@jkh52
Copy link
Contributor

jkh52 commented May 30, 2025

/lgtm
/hold

HOLD - please restore console.cloud.google.com (I think pantheon.corp.google.com works for googlers only)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2025
@cheftako
Copy link
Contributor Author

cheftako commented Jun 11, 2025

HOLD - please restore console.cloud.google.com (I think pantheon.corp.google.com works for googlers only)

"console.cloud.google.com" returns a mostly empty page with a wanring All "*gcr.io" traffic is routed to Artifact Registry..

Good catch. Happy to use a different URL but it should probably be something which returns data. Does the URL https://console.cloud.google.com/artifacts/docker/k8s-staging-kas-network-proxy/us/gcr.io/proxy-server?gcrImageListsize=30 work for you @jkh52?

@jkh52
Copy link
Contributor

jkh52 commented Jun 12, 2025

HOLD - please restore console.cloud.google.com (I think pantheon.corp.google.com works for googlers only)

"console.cloud.google.com" returns a mostly empty page with a wanring All "*gcr.io" traffic is routed to Artifact Registry..

Good catch. Happy to use a different URL but it should probably be something which returns data. Does the URL https://console.cloud.google.com/artifacts/docker/k8s-staging-kas-network-proxy/us/gcr.io/proxy-server?gcrImageListsize=30 work for you @jkh52?

Yes, that URL looks good.

@cheftako
Fix release instructions.
79ea18a 
Ensure the how to create a branch instructions are *before* tagging the
branch.
Fixed the location for looking up image locations.
Added us of RELEASE variable to branch tagging instructions.
Fixed corp URL to public URL.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@cheftako
Copy link
Contributor Author

cheftako commented Jun 12, 2025

HOLD - please restore console.cloud.google.com (I think pantheon.corp.google.com works for googlers only)

"console.cloud.google.com" returns a mostly empty page with a wanring All "*gcr.io" traffic is routed to Artifact Registry..
Good catch. Happy to use a different URL but it should probably be something which returns data. Does the URL https://console.cloud.google.com/artifacts/docker/k8s-staging-kas-network-proxy/us/gcr.io/proxy-server?gcrImageListsize=30 work for you Joseph Anttila Hall?

Yes, that URL looks good.

Fixed. Please unhold if your happy :)

@jkh52
Copy link
Contributor

jkh52 commented Jun 13, 2025

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit b07cd6d into kubernetes-sigs:master Jun 13, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkh52 jkh52 Awaiting requested review from jkh52

@elmiko elmiko Awaiting requested review from elmiko

@ipochi ipochi Awaiting requested review from ipochi

Assignees

@jkh52 jkh52

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cheftako @k8s-ci-robot @jkh52 @tallclair